Bump MSRV to 1.61.0 #3809
Bump MSRV to 1.61.0 #3809
Conversation
This is required by `image` crate. Also update current Rust version to 1.65.0.
link2xt
force-pushed
the
link2xt/msrv-1.61
branch
from
d007190
to
4df5886
Compare
| @@ -1 +1 @@ | |||
| 1.61.0 | |||
| 1.65.0 | |||
There was a problem hiding this comment.
if we are testing the msrv why not delete this file and let us always develop against the latest version? The ci.yml could then also use stable instead of having to code this version in.
There was a problem hiding this comment.
This file is currently used by deltachat-android build tools and scripts, I don't want to break them right now: https://github.com/deltachat/deltachat-android/blob/master/scripts/install-toolchains.sh and https://github.com/deltachat/deltachat-android/blob/master/scripts/ndk-make.sh
It ensures that we always know which version of Rust is currently used for android builds at least.
There was a problem hiding this comment.
I personally just use whatever rust comes from the distro repositories, without rustup.
There was a problem hiding this comment.
huh, interesting. which distro do you use that it gives you a good enough rust setup?
There was a problem hiding this comment.
Arch Linux has rust 1.65 in the repository, various cargo plugins and also a rustup package if you really need it.
There was a problem hiding this comment.
But also Debian sid has a recent enough version usually in sid, it's 1.62 currently, still good enough to compile deltachat-core-rust after this change.
|
@r10s you will need to run |
This is required by
imagecrate.env_loggerandaxumrequire 1.60.0.Also update current Rust version to 1.65.0.